Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated .spec.running field #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove usage of deprecated .spec.running field #48

wants to merge 1 commit into from

Conversation

RamLavi
Copy link

@RamLavi RamLavi commented Dec 16, 2024

What this PR does / why we need it:
The .spec.running field is deprecated, therefore we should runStrategy instead.

For more info, look at:
kubevirt/kubevirt#11993i

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 16, 2024
@RamLavi
Remove usage of deprecated .spec.running field
37a08b9 
The .spec.running field is deprecated, therefore we should
runStrategy instead.

For more info, look at:
kubevirt/kubevirt#11993i

Signed-off-by: Ram Lavi <[email protected]>
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cwilkers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cwilkers
cwilkers reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@cwilkers cwilkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this as a comment; I think this serves the same purpose in the lesson, but for the 101 example, I would like to verify the default is a stopped vm still.

kubevirt-101/step2.md
@@ -15,7 +15,7 @@ kubectl get vms
```{{execute}}

```
kubectl get vms -o yaml testvm | grep -E 'running:.*|$'
kubectl get vms -o yaml testvm | grep -E 'runStrategy:.*|$'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the default runStrategy set to effectively be the same as stopped? i.e. if none is specified, does the student still need to verify they are stopped and use virtctl to start them?

Copy link
Author

@RamLavi RamLavi Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running: true equals runStrategy: Always
and running: false equals runStrategy: Halted
no need to check virtctl.

@aburdenthehand
Copy link
Member

/lgtm
But @cwilkers will have to approve. Which brings up the need for us to find some new reviewer/approvers for this repo.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2024
@kubevirt-bot
Copy link

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwilkers cwilkers cwilkers left review comments

@jobbler jobbler Awaiting requested review from jobbler

Assignees

@aburdenthehand aburdenthehand

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RamLavi @kubevirt-bot @aburdenthehand @cwilkers